Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace for Agones infrastructure #89

Closed
markmandel opened this issue Feb 11, 2018 · 4 comments
Closed

Namespace for Agones infrastructure #89

markmandel opened this issue Feb 11, 2018 · 4 comments
Assignees
@markmandel
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented
Milestone
0.1

Comments

@markmandel
Copy link
Member

Should the controller and associated for Agones run under an agones-system (or similar) namespace?

Motivated because we'll need a Service and need to specify the namespace for webhooks for MutatingWebhookConfiguration and ValidatingWebhookConfiguration
@markmandel markmandel added the kind/design Proposal discussing new features / fixes and how they should be implemented label Feb 11, 2018
@cyriltovena
Copy link
Collaborator

I'd say yes but that will affect rbac.

@EricFortin
Copy link
Collaborator

I would say yes too and I think it is a best practice with RBAC anyway.

@markmandel
Copy link
Member Author

@dzlier-gcp if I implement this - will this break your RBAC configurations?

(I can either do it before or after #86 / #57 gets completed)

@markmandel markmandel added the good first issue These are great first issues. If you are looking for a place to start, start here! label Feb 12, 2018
@dzlier-gcp
Copy link
Contributor

rbac can always be updated with new service account names[paces], we just need to update the install.yaml file to account for it.

@markmandel markmandel self-assigned this Feb 12, 2018
markmandel added a commit that referenced this issue Feb 12, 2018
@markmandel
Move Agones resources into a agones-system namespace.
b117966 
This is setup work for #10 and #70, since the service for
webhooks need to be namespaced.

Closes #89
@markmandel markmandel mentioned this issue Feb 12, 2018
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
4 participants
@markmandel @cyriltovena @EricFortin @dzlier-gcp