Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some typos. #112

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fixed some typos. #112

merged 1 commit into from
Feb 27, 2018

Conversation

EricFortin
Copy link
Collaborator

I found one reviewing validation code. I decided to not stop at one and fixed a couple of others in the same file.

@googlebot
Copy link

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@EricFortin
Copy link
Collaborator Author

EricFortin commented Feb 26, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@markmandel
Copy link
Member

Step #3: mkdir -p ~/.kube
Step #3: mkdir -p /workspace/build//.config/gcloud
Step #3: docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube:/root/.kube -v /workspace:/go/src/agones.dev/agones agones-build:0229fec933 go test -race agones.dev/agones/...
Step #3: # agones.dev/agones/pkg/apis/stable/v1alpha1
Step #3: src/agones.dev/agones/pkg/apis/stable/v1alpha1/types.go:198:87: syntax error: unexpected newline, expecting comma or }
Step #3: # agones.dev/agones/pkg/apis/stable/v1alpha1
Step #3: src/agones.dev/agones/pkg/apis/stable/v1alpha1/types.go:198:87: syntax error: unexpected newline, expecting comma or }
Step #3: make: *** [test] Error 2
Step #3: Makefile:102: recipe for target 'test' failed

Looks like you accidentally removed the , at the end of line 198.

@EricFortin
Copy link
Collaborator Author

Thanks Mark, I fixed it. There's a unwritten rule somewhere stating that your first PR must not build right?

@markmandel
Copy link
Member

Awesome. final thing 😄 can we rebase down to 1 commit, and I'll give this the 👍

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit c4ac3a3 into master Feb 27, 2018
@markmandel markmandel deleted the small-typos branch February 27, 2018 00:45
@markmandel markmandel added this to the 0.1 milestone May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants