Centralise the canonical import paths and more package docs #130
Conversation
markmandel
added
kind/bug
markmandel
force-pushed
the
bug/godoc-imports
branch
4 times, most recently
from
3300f62
to
5e4f24b
Compare
|
/cc @enocom as I know you had opinions 😄 |
|
.. or maybe it actually makes more sense to drop this into 0.2 and play the safe game. WDYT? |
|
@markmandel Yeah. Definitely a nice to have. It's probably just a matter of finding the convention and following it. |
|
SGTM. Moving to 0.2, and this PR can be a thread on how we want to have a convention on this. |
|
Take a look at google-cloud-go. The top level If that's any guide, then the single restriction in the |
|
From going from your above code - maybe there should be an That would seem to make more sense? |
|
Putting the restriction in a |
|
Build Succeeded 👏 Build Id: 7b8b3817-33e6-4e6e-837c-0450f3e63328 The following development artifacts have been built, and will exist for the next 30 days:
|
Put the canonical import path into the main directory, to centralise it, and make sure it's applied across everything. As a side effect of this work, also added some more package docs.
markmandel
force-pushed
the
bug/godoc-imports
branch
from
5e4f24b
to
deae857
Compare
markmandel
changed the title
|
Done! PTAL. |
|
Build Succeeded 👏 Build Id: 3b6ce222-b669-4781-bb02-0734b0f43c8e The following development artifacts have been built, and will exist for the next 30 days:
|
Put the canonical import path into the main directory, to centralise it, and make sure it's applied across everything.
As a side effect of this work, also added some more package docs.