Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go vet: 3 warnings, 2 of them are easy. #139

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

Deleplace
Copy link
Contributor

$ go test ./...
(ok)
$ go vet ./...
examples/simple-udp/server/main.go:110: unreachable code
exit status 1
pkg/client/clientset/versioned/fake/clientset_generated.go:45: literal copies lock value from fakePtr: agones.dev/agones/vendor/k8s.io/client-go/testing.Fake
exit status 1
pkg/gameservers/helper_test.go:147: possible formatting directive in Error call
exit status 1

Files edit

$ go test ./...
(ok)
$ go vet ./...
pkg/client/clientset/versioned/fake/clientset_generated.go:45: literal copies lock value from fakePtr: agones.dev/agones/vendor/k8s.io/client-go/testing.Fake
exit status 1

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 13, 2018
@markmandel markmandel added this to the 0.2 milestone Mar 13, 2018
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3ebf7aa-8707-4fd9-879a-62d5edfcb0b4

The following development artifacts have been built, and will exist for the next 30 days:

@enocom enocom merged commit bc575f8 into googleforgames:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants