Fix some Go Report Card warnings #162
Conversation
|
Build Succeeded 👏 Build Id: 4efe73f7-e677-41cc-a670-3c900942a729 The following development artifacts have been built, and will exist for the next 30 days:
|
|
Build Succeeded 👏 Build Id: 948eba5a-57b4-4dd0-92e7-086f7b4529b2 The following development artifacts have been built, and will exist for the next 30 days:
|
| n, err := conn.Read(b) | ||
| if err != nil { | ||
| log.Fatalf("Could not read packet: %v", err) | ||
| n, errRead := conn.Read(b) |
There was a problem hiding this comment.
Catching these kinds of things are why the linters are so helpful.
There was a problem hiding this comment.
@enocom Does that mean you'll integrate gometalinter into the cloudbuild.yaml system? 😄
It's already in the build image.
There was a problem hiding this comment.
Yeah, that sounds like a great idea. I've been wanting to look at the build.
There was a problem hiding this comment.
Added #163 to track the work.
* fix misspell * add err check and fix var shadowing * fix crd package comment
|
Build Succeeded 👏 Build Id: 1aa54e11-7947-4be2-b625-a9a83d8a55b4 The following development artifacts have been built, and will exist for the next 30 days:
|
Many of golint warnings are in autogenerated files.