Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop and Build on Windows (WSL) with Minikube #59

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

markmandel
Copy link
Member

This implements several things:

  • An OS detection and include system for the build/Makefile
  • Removal of the option to build directly on Minikube. This was
    just too much complexity, especially across platform, and
    essentially wasn't really needed.
  • Documentation of how developing on Windows works.

Closes #47

This implements several things:
- An OS detection and include system for the `build/Makefile`
- Removal of the option to build directly on Minikube. This was
  just too much complexity, especially across platform, and
  essentially wasn't really needed.
- Documentation of how developing on Windows works.

Closes #47
@markmandel
Copy link
Member Author

@Kuqd and @dzlier-gcp - you may find this PR interesting 😁

@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jan 17, 2018
@markmandel markmandel added this to the 0.1 milestone Jan 17, 2018
@cyriltovena
Copy link
Collaborator

I'll give a try

@cyriltovena
Copy link
Collaborator

cyriltovena commented Jan 17, 2018

Everything is working fine. This will greatly help once merged.

I had issue with proxy but find my way around by modifying a bit the makefile. (not sure it's worth adding)

I also found a way to not enforce the bind mount and keep working on /mnt/c or /mnt/[a-z] by adding this in your windows.mk

# transform the path from windows to WSL
win_to_wsl_path := sed -e 's|\([A-Z]\):|/mnt/\L\1|' -e 's|\\|/|g'

# find the cert path
cert_path = $(realpath $(shell $(MINIKUBE) docker-env --shell bash | grep DOCKER_CERT_PATH | awk -F "=" '{ print $$2 }' | sed 's/"//g' | $(win_to_wsl_path))/..)


# avoid bindmount and allow usage of /mnt/{drive} on wsl
cert_path := $(subst /mnt/,/,$(cert_path))
common_mounts := $(subst /mnt/,/,$(common_mounts))

I'm rewriting path and include /mnt/ in your win_to_wsl_path.

Good job !

@markmandel
Copy link
Member Author

Awesome - glad it worked for you!

Removing the need for the bindmount would be nice (but it would be great it it worked with both with and without!)

I was going to suggest that I merge what I have now, and you submit a separate PR with your changes - so we can test with and without the bindmount, and adjust the documentation accordingly.

I have a feeling that what you have above will fail if the agon cluster hasn't been created yet (I'm not in front of my Windows PC at the moment, so can't test)

Unless you feel strongly that working without bindmount is very important for this PR?

@cyriltovena
Copy link
Collaborator

sure go ahead and merge !

@markmandel markmandel merged commit 6500d4d into master Jan 17, 2018
@markmandel markmandel deleted the feature/minikube-windows branch January 17, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants