feat: add support for GraalVM build #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
enable-graalvm-ci
branch
from
b000e65
to
2b8bc90
Compare
ttosta-google
changed the title
ttosta-google
changed the title
ttosta-google
force-pushed
the
enable-graalvm-ci
branch
from
b979c6a
to
f07abfe
Compare
ttosta-google
requested review from
kolea2,
cthumuluru,
nancynh and
a team
as code owners
enocom
reviewed
Oct 31, 2023
alloydb-jdbc-connector/src/main/java/com/google/cloud/alloydb/nativeimage/AlloyDBFeature.java
Outdated
Show resolved
Hide resolved
jackwotherspoon
suggested changes
Oct 31, 2023
ttosta-google
force-pushed
the
enable-graalvm-ci
branch
from
6aeec75
to
c44c3cb
Compare
enocom
approved these changes
Oct 31, 2023
ttosta-google
force-pushed
the
enable-graalvm-ci
branch
from
c44c3cb
to
d8400a8
Compare
jackwotherspoon
approved these changes
Nov 1, 2023
.github/workflows/ci.yaml
Outdated
Comment on lines
193
to
194
| # only run flakybot on periodic (schedule) and continuous (push) events | ||
| if: ${{ (github.event_name == 'schedule' || github.event_name == 'push') && runner.os == 'Linux' && always() }} |
There was a problem hiding this comment.
If the parent level job is only being run on schedule then this child check is unnecessary and can be removed
Suggested change
| # only run flakybot on periodic (schedule) and continuous (push) events | |
| if: ${{ (github.event_name == 'schedule' || github.event_name == 'push') && runner.os == 'Linux' && always() }} | |
| # run flakybot even on failures | |
| if: always() |
There was a problem hiding this comment.
Removed. Thanks!
jackwotherspoon
suggested changes
Nov 1, 2023
jackwotherspoon
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
As discussed the GraalVM job will run on periodic (schedule) event as it takes from 7 to 10min to finish (example)