Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google credentials to connector config #287

Closed
ttosta-google opened this issue Nov 8, 2023 · 0 comments · Fixed by #296
Closed

Add google credentials to connector config #287

ttosta-google opened this issue Nov 8, 2023 · 0 comments · Fixed by #296
Assignees
@ttosta-google
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ttosta-google
Copy link
Contributor

ttosta-google commented Nov 8, 2023 •
edited
Loading

Feature Description

Provides new configuration fields ConnectorConfig that allow the user to connectors use a specific GoogleCredential. users may set one of these three fields:

  • Supplier<GoogleCredentials> googleCredentialsSupplier - a supplier to provide GoogleCredentials instances to the connector.
  • GoogleCredentials googleCredentials - an instance of GoogleCredentials to use for all requests.
  • String googleCredentialsPath - path to file containing GoogleCredentials json.

Adds a JDBC Connection Property alloydbGoogleCredentialsPath to set the googleCredentialsPath field.

This is porting GoogleCloudPlatform/cloud-sql-jdbc-socket-factory#1675 to alloydb-java-connector.
@ttosta-google ttosta-google added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 8, 2023
@ttosta-google ttosta-google self-assigned this Nov 8, 2023
@ttosta-google ttosta-google mentioned this issue Nov 10, 2023
Merged
@ttosta-google ttosta-google changed the title Add google credentials path to connector config Add google credentials to connector config Nov 11, 2023
@ttosta-google ttosta-google mentioned this issue Nov 11, 2023
Merged
@ttosta-google ttosta-google mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttosta-google ttosta-google

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set the GoogleCredentials to use on a connector GoogleCloudPlatform/alloydb-java-connector
1 participant
@ttosta-google