docs: move driver-specific info to separate file #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
requested review from
kolea2,
cthumuluru,
nancynh and
a team
as code owners
enocom
requested changes
Nov 9, 2023
README.md
Outdated
| @@ -34,6 +34,10 @@ This library provides a [socket factory][socket-factory] for use with the | |||
| 1. Configure a connection pool that configures the driver to use the Connector | |||
| as a socket factory | |||
|
|
|||
| For usage information specific to your database engine and driver, see the pages below: | |||
There was a problem hiding this comment.
AlloyDB will always be Postgres only. And since we only support JDBC right now, perhaps we say, "For information on configuring a connection, see" or something generic like that.
There was a problem hiding this comment.
Updated. Thanks!
enocom
approved these changes
Nov 9, 2023
ttosta-google
force-pushed
the
reorganize-docs
branch
from
71a1c41
to
a1ab328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289