feat: add shutdown() to ConnectorRegistry #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
gh-305-add-shutdown
branch
2 times, most recently
from
5e83ef1
to
dfdd571
Compare
ttosta-google
requested review from
kolea2,
cthumuluru,
nancynh and
a team
as code owners
enocom
reviewed
Dec 8, 2023
|
|
||
| /** Calls shutdown on the singleton. */ | ||
| public void shutdownInstance() { | ||
| shutdown = true; |
There was a problem hiding this comment.
yes. Thanks for catching that.
ttosta-google
force-pushed
the
gh-305-add-shutdown
branch
from
dfdd571
to
783d83d
Compare
ttosta-google
force-pushed
the
gh-305-add-shutdown
branch
from
783d83d
to
93d8d44
Compare
enocom
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305