feat: add support for public IP #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttosta-google
force-pushed
the
gh-368-public-ip
branch
2 times, most recently
from
8eec590
to
d0611b3
Compare
ttosta-google
requested review from
kolea2,
cthumuluru,
nancynh and
a team
as code owners
| public enum IpType { | ||
| PUBLIC, | ||
| PRIVATE, | ||
| PSC; |
There was a problem hiding this comment.
We are not adding PSC support to the connectors just yet I believe. I think we want to wait on this until we have tested appropriately...
| @@ -78,6 +78,7 @@ public ListenableFuture<ConnectionInfo> getConnectionInfo( | |||
|
|
|||
| return new ConnectionInfo( | |||
| info.getIpAddress(), | |||
| info.getPublicIpAddress(), | |||
There was a problem hiding this comment.
What if an instance does not have a Public IP, does this fail nicely...?
There was a problem hiding this comment.
It returns an empty string.
I've updated the connector to raise an exception when IP address is not provided.
Thanks for you review.
ttosta-google
force-pushed
the
gh-368-public-ip
branch
from
f1d9d32
to
b116115
Compare
enocom
added
the
do not merge
ttosta-google
force-pushed
the
gh-368-public-ip
branch
from
3d4418f
to
8598731
Compare
enocom
removed
the
do not merge
ttosta-google
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368