Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage Checker should report clearer error when an artifact name is incorrect #1911

Open
suztomo opened this issue Jan 14, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed p2

Comments

@suztomo
Copy link
Contributor

suztomo commented Jan 14, 2021

Linkage Checker should report more clear error when an artifact name is incorrect. As of now, it fails with "IndexOutOfBoundsException" when a user passes invalid artifact ID:

Thu 14 Jan 2021 10:24:42 PM UTC: Running linkage check (validate) for beam-sdks-java-core   beam-sdks-java-io-google-cloud-platform   beam-runners-google-cloud-dataflow-java   beam-sdks-java-io-hadoop-format sdks-java-io-kinesis sdks-java-extensions-sql-zetasql
Thu 14 Jan 2021 10:24:42 PM UTC: using baseline build/linkagecheck/baseline-sdks-java-extensions-sql-zetasql.xml
+ ./gradlew -Ppublishing -PskipCheckerFramework -PjavaLinkageArtifactIds=sdks-java-extensions-sql-zetasql -PjavaLinkageReadBaseline=build/linkagecheck/baseline-sdks-java-extensions-sql-zetasql.xml :checkJavaLinkage
Configuration on demand is an incubating feature.

> Task :checkJavaLinkage FAILED
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Exception in thread "main" java.lang.IndexOutOfBoundsException: end index (1) must not be greater than size (0)
        at com.google.common.base.Preconditions.checkPositionIndexes(Preconditions.java:1420)
        at com.google.common.collect.ImmutableList.subList(ImmutableList.java:433)
        at com.google.cloud.tools.opensource.classpath.LinkageCheckerMain.main(LinkageCheckerMain.java:84)

FAILURE: Build failed with an exception.


@elharo elharo added enhancement New feature or request p2 help wanted Extra attention is needed good first issue Good for newcomers bug Something isn't working and removed enhancement New feature or request labels Jul 22, 2021
@elharo elharo changed the title Linkage Checker should report more clear error when an artifact name is incorrect Linkage Checker should report clearer error when an artifact name is incorrect Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed p2
Projects
None yet
Development

No branches or pull requests

2 participants