Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential false negatives on protected methods referenced from child class #2184

Open
suztomo opened this issue Aug 12, 2021 · 0 comments
Open
Labels

Comments

@suztomo
Copy link
Contributor

suztomo commented Aug 12, 2021

#2183 (comment) found an interesting case where Linkage Checker cannot report linkage errors for protected methods that are referenced from a child class. For example, the code below shows red for compilation error but Linkage Checker would not detect it if the relationship is in a class files.

Screen Shot 2021-08-12 at 16 18 25

This implies that when

  • a method in a library is changing its accessor from public to protected, and
  • the caller and callee has child-parent class relationship

Linkage Checker would fail to report the linkage errors. It considers that a protected method is ok to be accessed by child classes.

I'm not sure how to fix it but I think it's worth document here.

@suztomo suztomo added the p3 label Aug 12, 2021
@suztomo suztomo changed the title False negatives on protected methods Potential false negatives on protected methods referenced from child class Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant