Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpcio-gcp dependency for cloud spanner #5904

Merged
merged 3 commits into from
Sep 11, 2018

Conversation

WeiranFang
Copy link
Contributor

Add grpcio-gcp as extra dependency in google-api-core
Add grpcio-gcp as hard dependency in google-cloud-spanner

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 8, 2018

Making grpcio-gcp a hard dependency of google-cloud-spanner seems like it involves some risk: I don't know how well that package is supported across all the platforms, but for instance the latest version has a Python2-only wheel as its only binary distribution. I can't find its repository, either.

/cc @snehashah16

@theacodes
Copy link
Contributor

I'm going to send a PR to fix the wheel situation, then we can merge this.

The repo is at https://github.com/GoogleCloudPlatform/grpc-gcp-python

spanner/setup.py Outdated
@@ -30,7 +30,7 @@
release_status = 'Development Status :: 5 - Production/Stable'
dependencies = [
'google-cloud-core<0.29dev,>=0.28.0',
'google-api-core[grpc]<2.0.0dev,>=1.1.0',
'google-api-core[grpc, grpcio-gcp]<2.0.0dev,>=1.1.0',

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor

Universal wheel PR: GoogleCloudPlatform/grpc-gcp-python#99

@WeiranFang
Copy link
Contributor Author

WeiranFang commented Sep 10, 2018

Updated the min version for api_core and published universal wheel package for grpcio-gcp.

As for the release version for api-core and cloud-spanner, should I bump their versions now in this PR, or leave them for you guys when they are ready to release?

@theacodes
Copy link
Contributor

theacodes commented Sep 10, 2018 via email

@WeiranFang
Copy link
Contributor Author

No, releasetool will handle that.

Thanks! So the next step would be just to release api-core and cloud-spanner, right?

@theacodes
Copy link
Contributor

theacodes commented Sep 10, 2018 via email

@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

We can't get tests passing for this PR until api_core/setup.py has the new version number.

@WeiranFang
Copy link
Contributor Author

I think we should separate this into 2 pr, one for api core and another one for spanner. So we can release api core before spanner, correct?

@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

@WeiranFang This PR already touches api_core/setup.py: it just needs to bump the version number there so that the constraint in spanner/setup.py is satisfied. @theacodes will make the releases for the two in the order you suggest, but we can't merge without getting the tests passing first.

@WeiranFang
Copy link
Contributor Author

I see, thanks for the clarification!

@theacodes theacodes merged commit 24d590b into googleapis:master Sep 11, 2018
tseaver added a commit that referenced this pull request Sep 21, 2018
#5904 made 'grpcio-gcp' an unconditional dependency.
tseaver added a commit that referenced this pull request Sep 22, 2018
#5904 made 'grpcio-gcp' an unconditional dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants