Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on fasteners >= 0.16 to remove obselete dependency on monotonic #1686

Open
Zac-HD opened this issue Mar 30, 2023 · 0 comments
Open

Depend on fasteners >= 0.16 to remove obselete dependency on monotonic #1686

Zac-HD opened this issue Mar 30, 2023 · 0 comments

Comments

@Zac-HD
Copy link

Zac-HD commented Mar 30, 2023

gsutil declares a dependency on the obsolete monotonic package, which was a substitute for the stdlib time.monotonic() function before that was available on all platforms (from Python 3.5 onwards).

However, this is only necessary for the very old vendored copy of fasteners (at v0.14), which at version 0.16 dropped this dependency. In my environment, the monotonic package is never used at all: gsutil doesn't use it directly, and the version of fasteners I'm using doesn't use it either.

I'd therefore encourage you to drop this un-needed and obsolete dependency, either by updating the vendored copy of fasteners, or at least moving the dependency from gsutil into your vendored library so that it doesn't get pulled in from PyPI for other users. This may seem like a small thing but image size and auditing times add up surprisingly quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant