Use AR instead of GCR for whereami #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #209 |
* Please see [Use AR instead of GCR for Deployments GoogleCloudPlatform#209](GoogleCloudPlatform#209). * AR = Artifact Registry * GCR = Google Container Registry * This pull-request for `whereami:v1.2.6`: * I'm replacing instances of the images' GCR URLs with the equivalent AR URLs. * `gcr.io/google-samples/whereami:v1.2.6` → `us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6` So once merged, I would have to update the above tutorials via [this Google-internal content publisher](https://devsite.corp.google.com/publisher). We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so: 1. Pull the 2 images you want to compare: ``` docker image pull gcr.io/google-samples/whereami:v1.2.6 docker image pull us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6 ``` 2. Inspecting both images: ``` docker image inspect gcr.io/google-samples/whereami:v1.2.6 docker image inspect us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6 ``` 3. See that the [RootFS values match](https://stackoverflow.com/questions/46321878/how-to-verify-if-the-content-of-two-docker-images-is-exactly-the-same/46322160#46322160).
irvifa
force-pushed
the
feat/use-ar-instead-of-gcr
branch
from
1f46946
to
72b9527
Compare
NimJay
changed the title
NimJay
changed the title
NimJay
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Thank you so much for preparing this pull-request, @irvifa! 👏
The RootFS values of the images match.
We will also need to update whereami/README.md; that is, we'll need to replace the instances of gcr.io/google-samples/whereami:v1.2.6. I will prepare a separate pull-request for this.
Approved. And merging.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see Use AR instead of GCR for Deployments #209.
AR = Artifact Registry
GCR = Google Container Registry
This pull-request for
whereami:v1.2.6:I'm replacing instances of the images' GCR URLs with the equivalent AR URLs.
gcr.io/google-samples/whereami:v1.2.6→us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6So once merged, I would have to update the above tutorials via this Google-internal content publisher.
We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so: