From cd982ea2c35a46a9c10231bfa01a254d629a30f4 Mon Sep 17 00:00:00 2001 From: Nathan McKinley Date: Tue, 24 Sep 2019 14:34:47 -0700 Subject: [PATCH] cloudbuild build trigger's trigger template should be required in 3.0.0. (#2352) * cloudbuild build trigger's trigger template should be required in 3.0.0. --- products/cloudbuild/api.yaml | 1 + products/cloudbuild/terraform.yaml | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/products/cloudbuild/api.yaml b/products/cloudbuild/api.yaml index 8943af8b8e30..229d60969fa2 100644 --- a/products/cloudbuild/api.yaml +++ b/products/cloudbuild/api.yaml @@ -113,6 +113,7 @@ objects: Branch and tag names in trigger templates are interpreted as regular expressions. Any branch or tag change that matches that regular expression will trigger a build. + required: true properties: - !ruby/object:Api::Type::String name: 'projectId' diff --git a/products/cloudbuild/terraform.yaml b/products/cloudbuild/terraform.yaml index 22cb1ad323fb..cbfbb0a330f9 100644 --- a/products/cloudbuild/terraform.yaml +++ b/products/cloudbuild/terraform.yaml @@ -30,9 +30,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides default_from_api: true build.steps: !ruby/object:Overrides::Terraform::PropertyOverride name: 'step' - triggerTemplate: !ruby/object:Overrides::Terraform::PropertyOverride - description: | - {{description}}This field is required, and will be validated as such in 3.0.0. triggerTemplate.projectId: !ruby/object:Overrides::Terraform::PropertyOverride default_from_api: true custom_code: !ruby/object:Provider::Terraform::CustomCode