Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for payments and currency service #216

Closed
dineshnagarit opened this issue May 14, 2019 · 3 comments
Closed

Add test cases for payments and currency service #216

dineshnagarit opened this issue May 14, 2019 · 3 comments

Comments

@dineshnagarit
Copy link
Contributor

There should be unit test cases for payments and currency microserivce.

@dineshnagarit dineshnagarit changed the title Write test cases for payments and currency service. We should have test cases for payments and currency service. May 14, 2019
@ahmetb
Copy link
Contributor

ahmetb commented May 14, 2019

We have limited test cases in most microservices, mostly because it’s a demo app.
However if you can contribute some, and make them part of the build process (probably the Dockerfile?) it’d be appreciated.

@ahmetb ahmetb changed the title We should have test cases for payments and currency service. Add test cases for payments and currency service May 17, 2019
@dineshnagarit
Copy link
Contributor Author

@ahmetb I am planing to work on this next week, I will keep you updated about the progress.

@daniel-sanche
Copy link
Member

We're closing this and other kind/improvement issues as we attempt to move the project into a stable maintenance state. Let me know if still plan on working on this and I can re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants