-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate for container images in Kubernetes manifests #1310
Renovate for container images in Kubernetes manifests #1310
Conversation
🚲 PR staged at http://35.223.27.27 |
1 similar comment
🚲 PR staged at http://35.223.27.27 |
Ready for review, thanks! |
renovate.json
Outdated
@@ -39,5 +39,8 @@ | |||
}, | |||
"npm":{ | |||
"addLabels": ["lang: nodejs"] | |||
}, | |||
"kubernetes": { | |||
"fileMatch": ["\\.yaml$"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
We should ignore release/
and kustomize/base/
since these folders are only modified when we create new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use ignorePaths
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, just updated it accordingly.
🚲 PR staged at http://35.223.27.27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for doing this, Mathieu.
FYI, like expected this update has been caught thanks to this PR: #1313 |
We could also see that the Dependency Dashboard now has |
…tform#1310) * Renovate for container images in Kuberentes manifests * Update renovate.json * ignorePaths
https://docs.renovatebot.com/modules/manager/kubernetes/
As soon as it's merged in
main
, the goal is to catch any update of any container images referenced in any Kubernetes manifests. Like for example https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/kustomize/components/google-cloud-operations/otel-collector.yaml#L71