make recommendation service optional #1332
Conversation
|
Thanks for taking to initiative and opportunity to fix this, @katzio. Much appreciated! |
There was a problem hiding this comment.
I haven't tested myself, but this LGTM!
The associated application deployed (with recommendationservice working so not testing this PR per say) is working as expected: http://34.136.184.173/.
We want the same behavior as adservice, and I can see that you did the exact same code like here https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/src/frontend/handlers.go#L432.
Thanks again!
Before merging, let's have a final approval by @NimJay on this.
|
Actually, I just tested in our test environment (for this PR), and we could see that there is no error anymore on the Product page if |
There was a problem hiding this comment.
@katzio, thanks so much for looking into this and implementing it.
I didn't think the change would be this simple.
This is great!
@mathieu-benoit, thank you for taking down the recommendationservice of the staging deployment. It worked!
Approved. Merging!
* support missing recommendation service * support in view cart * lint * improve comment
Background
make recommendation service optional like ad
Fixes
Change Summary
Frontend template already supports missing recommendations, removed
renderHTTPErrorbut kept logsAdditional Notes
should I add (error) log to placeOrderHandler?
Testing Procedure
Manually: turn off recommendations pod
Related PRs or Issues
addressing #1165