Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Helm chart with advanced scenarios #1385

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fix Helm chart with advanced scenarios #1385

merged 2 commits into from
Dec 12, 2022
+66 −206

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Dec 12, 2022 •
edited
Loading

  • Fix issue when exposed behind an Istio Ingress Gateway
  • Take into account opentelemetryCollector with Sidecars
  • Fix frontend's AuthorizationPolicy with Istio Ingress Gateway
  • Add a deny-all AuthorizationPolicy
  • Fix cartservice's Sidecar with redis name
  • Deploy the Helm chart via Config Sync (GitOps): errors with the license headers in empty file, we don't need these headers for these generated by Helm manifests
  • Do not trigger ci-main nor ci-pr when only updates in helm-chart/**

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner December 12, 2022 12:34
@github-actions
Copy link

🚲 PR staged at http://34.135.243.112

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://34.135.243.112

@NimJay NimJay merged commit b18e45e into main Dec 12, 2022
@mathieu-benoit mathieu-benoit deleted the mathieu-benoit/fix-helm-chart branch December 12, 2022 16:57
@mathieu-benoit mathieu-benoit self-assigned this Dec 12, 2022
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
Fix Helm chart with advanced scenarios (GoogleCloudPlatform#1385)
0452001 
* Fix Helm chart with advanced scenarios

* ignore helm-chart/** with ci-main and ci-pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

Assignees

@mathieu-benoit mathieu-benoit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @NimJay