Fix /hack/make-helm-chart.sh
#1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NimJay
commented
Dec 22, 2022
| sed -i "s/^appVersion:.*/appVersion: \"${TAG}\"/" Chart.yaml | ||
| sed -i "s/^version:.*/version: ${TAG:1}/" Chart.yaml | ||
| gsed -i "s/^appVersion:.*/appVersion: \"${TAG}\"/" Chart.yaml | ||
| gsed -i "s/^version:.*/version: ${TAG:1}/" Chart.yaml |
There was a problem hiding this comment.
The hack script uses gsed instead of sed.
Using gsed allows us to run sed commands on both Linux and Mac.
NimJay
commented
Dec 22, 2022
| helm package . | ||
| helm push onlineboutique-$TAG.tgz oci://$HELM_CHART_REPO | ||
| helm push onlineboutique-${TAG:1}.tgz oci://$HELM_CHART_REPO |
There was a problem hiding this comment.
The TAG environment variable's value looks like: v0.5.1.
Using ${TAG:1} means that we remove the v — leaving us with 0.5.1.
|
🚲 PR staged at http://35.238.49.121 |
mathieu-benoit
approved these changes
Dec 22, 2022
|
Thanks for the quick review/approva, @mathieu-benoit! :) |
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
make-helm-chart.shis run when a maintainer creates a new release of Online Boutique.make-helm-chart.shbumps up the version of the Helm Chart published atoci://us-docker.pkg.dev/online-boutique-ci/charts/onlineboutique.make-helm-chart.sh.Change Summary
Testing Procedure