Clean .tgz Helm chart files
#1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for your review, thanks! |
bourgeoisor
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
Good catch, Mathieu! Looks good to me.
Will let @NimJay merge / do a second look
NimJay
reviewed
Jun 5, 2023
NimJay
approved these changes
Jun 5, 2023
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Aug 24, 2023
* Update make-helm-chart.sh * Clean old .tgz Helm chart files * Add ./helm-chart/ in make-helm-chart.sh --------- Co-authored-by: Nim Jayawardena <[email protected]>
mrcrgl
pushed a commit
to fiberfjord/microservices-demo
that referenced
this pull request
Sep 11, 2023
* Update make-helm-chart.sh * Clean old .tgz Helm chart files * Add ./helm-chart/ in make-helm-chart.sh --------- Co-authored-by: Nim Jayawardena <[email protected]>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
* Update make-helm-chart.sh * Clean old .tgz Helm chart files * Add ./helm-chart/ in make-helm-chart.sh --------- Co-authored-by: Nim Jayawardena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When releasing (building and pushing) a new Helm chart, we then need to remove the temporary
.tgzfile, otherwise it's commited in source repo.