Remove nativeGrpcHealthCheck from Helm chart
#1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for your review, thanks! FYI: @NimJay |
NimJay
reviewed
Jun 15, 2023
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "v0.7.0" | ||
| appVersion: "v0.8.0" |
There was a problem hiding this comment.
Heads-up:
I've bumped this to 0.8.0 because I don't think the updates to the Helm charts will work on Online Boutique's 0.7.0 images.
I will be building and pushing the 0.8.0 images shortly.
NimJay
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Thanks so much for taking care of this, @mathieu-benoit.
The changes look good.
I'll be creating a new release shortly to ensure the update to 0.8.0 works.
Approved. Merging.
sitaramkm
pushed a commit
to sitaramkm/microservices-demo
that referenced
this pull request
Aug 24, 2023
) * Remove nativeGrpcHealthCheck from Helm chart * Remove entirely nativeGrpcHealthCheck in Helm chart * Update Chart.yaml to 0.8.0 --------- Co-authored-by: Nim Jayawardena <[email protected]> Co-authored-by: Nim Jayawardena <[email protected]>
mrcrgl
pushed a commit
to fiberfjord/microservices-demo
that referenced
this pull request
Sep 11, 2023
) * Remove nativeGrpcHealthCheck from Helm chart * Remove entirely nativeGrpcHealthCheck in Helm chart * Update Chart.yaml to 0.8.0 --------- Co-authored-by: Nim Jayawardena <[email protected]> Co-authored-by: Nim Jayawardena <[email protected]>
D-Mwanth
pushed a commit
to D-Mwanth/microservices-demo
that referenced
this pull request
Mar 6, 2024
) * Remove nativeGrpcHealthCheck from Helm chart * Remove entirely nativeGrpcHealthCheck in Helm chart * Update Chart.yaml to 0.8.0 --------- Co-authored-by: Nim Jayawardena <[email protected]> Co-authored-by: Nim Jayawardena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
nativeGrpcHealthCheckfrom Helm chart, following up on #1837.