Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct docs about native-gprc-health-check Kustomize component #1893

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Correct docs about native-gprc-health-check Kustomize component #1893

merged 2 commits into from
Jul 10, 2023
+0 −3

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Jul 7, 2023 •
edited
Loading

Background

Fixes

#1891

Change Summary

Testing Procedure

No testing needed.

@NimJay NimJay changed the title Remove built-in gRPC health check component from README.md Remove out-dated docs about builtnative-gprc-health-check Kustomize component Jul 7, 2023
@NimJay NimJay changed the title Remove out-dated docs about builtnative-gprc-health-check Kustomize component Correct docs about builtnative-gprc-health-check Kustomize component Jul 7, 2023
@NimJay NimJay changed the title Correct docs about builtnative-gprc-health-check Kustomize component Correct docs about native-gprc-health-check Kustomize component Jul 7, 2023
@NimJay NimJay mentioned this pull request Jul 7, 2023
Closed
@NimJay NimJay marked this pull request as ready for review July 10, 2023 13:14
@NimJay NimJay requested review from a team and yoshi-approver as code owners July 10, 2023 13:14
@github-actions
Copy link

🚲 PR staged at http://34.69.143.90

bourgeoisor
bourgeoisor approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NimJay NimJay merged commit d6ad95f into main Jul 10, 2023
7 checks passed
@NimJay NimJay deleted the nimjay-remove-health-check-docs branch July 10, 2023 16:41
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Aug 24, 2023
@NimJay @sitaramkm
Correct docs about native-gprc-health-check Kustomize component (Goog…
0f59115 
…leCloudPlatform#1893)

* Remove built-in gRPC health check component from README.md

* Remove native-grpc-health-check comment
mrcrgl pushed a commit to fiberfjord/microservices-demo that referenced this pull request Sep 11, 2023
@NimJay @mrcrgl
Correct docs about native-gprc-health-check Kustomize component (Goog…
5274441 
…leCloudPlatform#1893)

* Remove built-in gRPC health check component from README.md

* Remove native-grpc-health-check comment
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@NimJay
Correct docs about native-gprc-health-check Kustomize component (Goog…
0d2b826 
…leCloudPlatform#1893)

* Remove built-in gRPC health check component from README.md

* Remove native-grpc-health-check comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor