-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minikube installation instructions added #209
Minikube installation instructions added #209
Conversation
Tested with Minikube+KVM (4 CPU; 4GB RAM). Signed-off-by: Ihor Dvoretskyi <[email protected]>
we strive to keep the "number of options" low to run this demo app. so we should probably kill the "docker for desktop" option in favor of minikube. what do you think? |
Fine with that, but we'll need someone to test this with Minikube on Mac/Windows (I don't have them). |
I'm trying this, so far it crashed in the middle of
|
Second build succeeded and it seems to be working OK (on 4cpus/3096MB). Most notably, the last step of the local instructions needs to be changed from
to
Sadly the URL looks much less intiutive, like But other than that, I can't seem to find any problems. |
Found another somewhat interesting problem. Many users of this demo app are Googlers, and they all use the same browser with a corp proxy extension preinstalled. When they go to the As a result, they will go to an error page that reads |
@tstromberg do you have any suggestions on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by review as I was filing an issue request. Hope you don't mind :)
Cheers
-steve
Thank you @sdake, I'll address your comments. |
Signed-off-by: Ihor Dvoretskyi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with Minikube+KVM (4 CPU; 4GB RAM).
Signed-off-by: Ihor Dvoretskyi [email protected]