Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube installation instructions added #209

Merged

Conversation

idvoretskyi
Copy link
Contributor

Tested with Minikube+KVM (4 CPU; 4GB RAM).

Signed-off-by: Ihor Dvoretskyi [email protected]

Tested with Minikube+KVM (4 CPU; 4GB RAM).

Signed-off-by: Ihor Dvoretskyi <[email protected]>
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@ahmetb
Copy link
Contributor

ahmetb commented Apr 23, 2019

we strive to keep the "number of options" low to run this demo app.

so we should probably kill the "docker for desktop" option in favor of minikube. what do you think?

@idvoretskyi
Copy link
Contributor Author

so we should probably kill the "docker for desktop" option in favor of minikube. what do you think?

Fine with that, but we'll need someone to test this with Minikube on Mac/Windows (I don't have them).

@ahmetb
Copy link
Contributor

ahmetb commented Apr 25, 2019

I'm trying this, so far it crashed in the middle of skaffold run with no error once (4 CPUs, 3GiB RAM):

...
Step 3/16 : ENV PROJECT github.com/GoogleCloudPlatform/microservices-demo/src/productcatalogservice
 ---> Running in f1c075448b0f
 ---> 3055a5df5d85
Step 4/16 : WORKDIR /go/src/$PROJECT
 ---> Running in 48564497716d
 ---> 45c1487fb1f3
Step 5/16 : COPY Gopkg.* ./
 ---> a7fc148b57b6
Step 6/16 : RUN dep ensure --vendor-only -v
 ---> Running in 53d8a267940d
(1/21) Wrote github.com/googleapis/[email protected]

@ahmetb
Copy link
Contributor

ahmetb commented Apr 25, 2019

Second build succeeded and it seems to be working OK (on 4cpus/3096MB).

Most notably, the last step of the local instructions needs to be changed from

Visit http://localhost:80

to

Run minikube service frontend-external --url and visit the URL

Sadly the URL looks much less intiutive, like http://192.168.64.2:31594 (not only it's not on port :80 as the Service spec defines, but also not exposed directly on localhost). Does Minikube offer anything to make this better?

But other than that, I can't seem to find any problems.

@ahmetb
Copy link
Contributor

ahmetb commented Apr 25, 2019

Found another somewhat interesting problem.

Many users of this demo app are Googlers, and they all use the same browser with a corp proxy extension preinstalled.

When they go to the http://192.168.64.2 like URL above, the proxy will treat the URL not local to the machine, but local to Google’s corporate network. (Docker for Mac doesn't have this problem as it uses localhost which never routes outside your machine.)

As a result, they will go to an error page that reads Failed to connect to the backend. because that IP is routed to our corp proxy. This will confuse Googlers quite a bit and we (particularly me) may get a lot of messages from new Googlers adopting this demo app for troubleshooting. 🤷‍♂️ I really wish there was a way to use localhost with Minikube.

@idvoretskyi
Copy link
Contributor Author

I really wish there was a way to use localhost with Minikube.

@tstromberg do you have any suggestions on this?

Copy link
Contributor

@sdake sdake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by review as I was filing an issue request. Hope you don't mind :)

Cheers
-steve

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@idvoretskyi
Copy link
Contributor Author

Thank you @sdake, I'll address your comments.

Signed-off-by: Ihor Dvoretskyi <[email protected]>
Copy link
Member

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants