Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ASM in Fleet, in service-mesh-istio/README.md #2243

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Enable ASM in Fleet, in service-mesh-istio/README.md #2243

merged 2 commits into from
Nov 5, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Nov 1, 2023 •
edited
Loading

Background

gcloud container fleet mesh enable --project PROJECT_ID
  • We forgot this step in Online Boutique's ASM instructions.
  • We didn't catch this issue before because we were testing on project that already had ASM enabled (on the project Fleet).

Change Summary

  • Add gcloud container fleet mesh enable --project ${PROJECT_ID} to the ASM instructions.

Testing Procedure

  • I don't think we need to do thorough testing here.
  • The command is valid:
Screenshot 2023-11-01 at 5 19 30 PM

CC: Thanks, @dkoss, for finding this issue.

@NimJay NimJay requested review from yoshi-approver and a team as code owners November 1, 2023 21:17
minherz
minherz approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minherz minherz self-assigned this Nov 3, 2023
@NimJay NimJay merged commit fdccc97 into main Nov 5, 2023
10 checks passed
@NimJay NimJay deleted the nimjay-fix-asm-instructions branch November 5, 2023 23:12
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@NimJay
Enable ASM in Fleet, in service-mesh-istio/README.md (GoogleCloudPlat…
43c27cb 
…form#2243)

* Enable ASM in Fleet, in service-mesh-istio/README.md

* Remove .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minherz minherz minherz approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@minherz minherz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @minherz