Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add note in README.md about variations #2265

Merged
merged 1 commit into from
Nov 20, 2023
Merged

docs: Add note in README.md about variations #2265

merged 1 commit into from
Nov 20, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Nov 16, 2023 •
edited
Loading

Background

  • I received feedback from a Googler that it was difficult to find the documentation about enabling tracing for Online Boutique.
  • They suggested adding:

a note in the github link to guide to enable the trace

  • Hence, I've added a similar note to the quickstart.

Testing Procedure

@NimJay NimJay requested review from yoshi-approver and a team as code owners November 16, 2023 20:28
@NimJay NimJay merged commit 866b61d into main Nov 20, 2023
8 checks passed
@NimJay NimJay deleted the nimjay-readme-quickstart branch November 20, 2023 17:36
D-Mwanth pushed a commit to D-Mwanth/microservices-demo that referenced this pull request Mar 6, 2024
@NimJay
docs: Add note in README.md about variations (GoogleCloudPlatform#2265)
ad3012e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor