fix: display service name in Cloud Trace #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚲 PR staged at http://34.72.176.161 |
NimJay
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thanks so much for this, @minherz!
I believe you covered all OTel-supporting microservices.
Approved. Merging. I have a quick question about moving some changes to the google-cloud-operations Kustomize component. See my other comment.
NimJay
reviewed
Jan 23, 2024
inject OTel service name env variable to enable display of service name in Cloud Trace
minherz
force-pushed
the
minherz/add-service-name
branch
from
8202b00
to
3d83a71
Compare
NimJay
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thank you for moving the changes from /kubernetes-manifests to the google-cloud-operations Kustomize component. Clean! And thanks for the super clear GitHub issue description.
Everything looks good. Approved. Merging.
I trust that you'd done adequate testing (and will be testing these changes when you resume work on your content).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes the display of the correct service name in Cloud Trace when the app is deployed with tracing enabled.
Fixes
#2349
Change Summary
Manifests of the services that ingest traces to Cloud Trace are updated with additional environment variable (
OTEL_SERVICE_NAME) that results in posting theservice.nameattribute with the correct value.Testing Procedure
Deploy the app (either using kustomize with
google-cloud-operationscomponent or using Helm with Google Cloud operations enabled and observe that all service names in the Trace details grid are known.