Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for updating major tag during release #2409

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Add instructions for updating major tag during release #2409

merged 4 commits into from
Mar 18, 2024

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Mar 7, 2024 •
edited
Loading

Background

Change Summary

  • I've introduced a git tag for each major release (currently just v0).

Testing Procedure

@NimJay NimJay marked this pull request as ready for review March 15, 2024 19:45
@NimJay NimJay requested review from yoshi-approver and a team as code owners March 15, 2024 19:45
bourgeoisor
bourgeoisor approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

NimJay
NimJay commented Mar 18, 2024
View reviewed changes
docs/releasing/README.md Outdated Show resolved Hide resolved
@NimJay
Copy link
Collaborator Author

NimJay commented Mar 18, 2024

Thank you, @bourgeoisor, for the quick and proactive review. Merging.

@NimJay NimJay merged commit 0ec2427 into main Mar 18, 2024
8 checks passed
@NimJay NimJay deleted the nimjay-major-tag branch March 18, 2024 17:00
azinneera pushed a commit to azinneera/microservices-demo that referenced this pull request Mar 29, 2024
@NimJay @azinneera
Add instructions for updating major tag during release (GoogleCloudPl…
0792d6b 
…atform#2409)

* Add instructions for updating major tag during release

* Update README.md (15 to 14)

* Unindent to match other code snippets in README.md

* Update docs/releasing/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor