Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run PR CI on most recent commit #2424

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Only run PR CI on most recent commit #2424

merged 2 commits into from
Mar 15, 2024

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Mar 15, 2024 •
edited
Loading

Background

  • Today, the code-tests and deployment-test GitHub Actions jobs get queued up for all commits of a pull-request.
  • But we only care about running these jobs for the most recent commit of a pull-request.

Change Summary

Testing Procedure

  • You'll see that it worked for the commits in this pull-request:

image

@NimJay NimJay marked this pull request as ready for review March 15, 2024 14:12
@NimJay NimJay requested review from yoshi-approver and a team as code owners March 15, 2024 14:12
bourgeoisor
bourgeoisor approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NimJay NimJay merged commit e2a1ab4 into main Mar 15, 2024
9 checks passed
@NimJay NimJay deleted the nimjay-workflow-concurrency branch March 15, 2024 14:21
@NimJay
Copy link
Collaborator Author

NimJay commented Mar 15, 2024 •
edited
Loading

Thanks for the super speedy review/approval, Olivier. ⚡

Looks like this change is doing it's thing:

image

@github-actions GitHub Actions
Copy link

🚲 PR staged at http://34.132.98.206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor