Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone latest major tag in Quickstart #2506

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Clone latest major tag in Quickstart #2506

merged 1 commit into from
Apr 22, 2024

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Apr 22, 2024 •
edited
Loading

Background

Change Summary

  • Use the latest major version in the root /README.md quickstart.

Additional Notes

Testing Procedure

  • I have tested this command manually:
git clone --depth 1 --branch v0 https://github.com/GoogleCloudPlatform/microservices-demo.git

@NimJay NimJay marked this pull request as ready for review April 22, 2024 17:55
@NimJay NimJay requested review from yoshi-approver and a team as code owners April 22, 2024 17:55
bourgeoisor
bourgeoisor approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the quickstart

@bourgeoisor bourgeoisor merged commit 6960a23 into main Apr 22, 2024
8 checks passed
@bourgeoisor bourgeoisor deleted the nimjay-major-tag branch April 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor