-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple release manifests #716
Conversation
Here is the summary of changes. You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
Thanks for initiating this, @bourgeoisor! I assume the changes from the PR will definitely require a "major" bump in the versioning of Online Boutique. |
Note from 1-on-1 with Olivier: |
Out of curiosity, @NimJay and @bourgeoisor, is this PR still a thing? Or should we close it and reconsider this in a future/following PR? We have limited number of PR opened with Renovate, so wondering if we can close this one? |
I'm happy with closing it (but also fine with leaving it open, especially, if we expect to make progress on this in the coming weeks). |
Let's close for now -- We can revisit when we implement kustomize and co. |
This PR simplifies the release making process and increases the consistency with the Bank of Anthos process (https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/main/release/make-release.sh)
Changes to note:
make-release.sh
script(s) has had its lines-of-code reduced by 120 (from 190 to 70)kubernetes-manifests/
directory was renamed todev-kubernetes-manifests/
(the "dev" manifests)release/
directory was renamed tokubernetes-manifests/
(the "release" manifests)istio-manifests/
directory stays as-isTODOs:
.md
files in this repo.yaml
files of GitHub workflowsOpen questions:
hacks/
directory torelease/
to match Bank of Anthos (https://github.com/GoogleCloudPlatform/bank-of-anthos/tree/main/release)?Testing
I have tested this with a fake release (
v1.1.1
):The images were pushed on my registry: