Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functions emulator from repo #1333

Closed
grant opened this issue Jun 3, 2019 · 5 comments
Closed

Remove functions emulator from repo #1333

grant opened this issue Jun 3, 2019 · 5 comments
Assignees
@ace-n

Comments

@grant
Copy link
Contributor

grant commented Jun 3, 2019

The Google Cloud Functions Emulator was never an official Google product as stated on the README and the tool has been deprecated.

Please remove all uses of the emulator from this repo.

Optionally replace references with the functions framework:
https://github.com/GoogleCloudPlatform/functions-framework-nodejs
@fhinkel
Copy link
Contributor

fhinkel commented Jun 5, 2019

See #1255

@grant
Copy link
Contributor Author

grant commented Jun 11, 2019

PR looking good. Should be merged soon.

@ace-n ace-n mentioned this issue Jun 11, 2019
Closed
@ace-n
Copy link
Contributor

ace-n commented Jun 11, 2019 •
edited
Loading

#1255 will help, but doesn't completely solve the problem. This is blocked on (Google internal) b/134942934.

@fhinkel
Copy link
Contributor

fhinkel commented Oct 3, 2019

We removed it from all the code - but the Readme's still list it

  • functions/helloworld/README.md
  • functions/speech-to-speech/README.md

This was referenced Oct 3, 2019
Closed
Merged
@fhinkel
Copy link
Contributor

fhinkel commented Oct 3, 2019

AFAIK this is fixed, please reopen if needed.

@fhinkel fhinkel closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhinkel @grant @ace-n