-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run: Move in the System Packages sample app #1436
Comments
Either way is fine assuming one doesn't make the image a lot bigger than the other, but I don't think so. |
Let me know how you want to move forward with this. Thanks! |
For alignment with how golang-samples will work, I'll add graphviz to the container. |
Sounds good. Closing this as resolved. Feel free to reopen if needed. |
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Staged Location: https://github.com/GoogleCloudPlatform/cloud-run-samples/tree/master/nodejs/system_package
This sample needs to be moved to nodejs-docs-samples so the tutorial can be updated to point to GitHub.
A core premise of the tutorial is its dependency on the graphviz system package. The tests will not pass without the presence of this package.
@fhinkel please provide feedback on your preference.
The text was updated successfully, but these errors were encountered: