iot CI failing

[fhinkel]

Hi @hongalex , I can't get the iot manager test to pass, e.g., on this PR

https://source.cloud.google.com/results/invocations/ae9e7ed3-31f2-4454-b0e3-57fef10e1b2d/targets/cloud-devrel%2Fnodejs-docs-samples%2Fpresubmit%2Fiot%2Fiot-manager/log

Refs

• Update dependency puppeteer to v2 #1526
• Task/add create fileset entry #1525

Could you have a look? Thanks

[fhinkel]

The iot/manager test failing seem to be related to this change:
googleapis/nodejs-iot@68a1d6e

Method name changed, but test from sample code was not updated.
client.registryPath -> client.deviceRegistryPath

[mesmacosta]

I sent a PR with a proposed fix: #1528

[fhinkel]

@hongalex @gguuss We deactivated the tests for now. Were you able to roll back the API change? Or should we adapt the test?

[gguuss]

@JustinBeckwith to comment on rolling back the breaking change, I lost track of the thread where this discussion was taking place and am currently traveling so I'm unable to really be very responsive here. The v0.3 iot library introduces the issue.

[gguuss]

We have this PR with a fix, I'm open to merging it and then resolving if we can roll back.

[fhinkel]

ping @JustinBeckwith

[JustinBeckwith]

Tracking in b/143947540

[gguuss]

This will be fixed when this PR merges.

[gguuss]

This is now fixed, thanks everyone!