functions/composer-storage-trigger/index.js sends nonexistent argument "iap.jwt" to "makeIapPostRequest"

[starmandeluxe]

It looks like the final argument in makeIapPostRequest ("jwt") was removed at some point (43cb78c#diff-03c121b657e9255e31ace2345598d678R152), but for some reason the code sample still provides it in the call to this function:

nodejs-docs-samples/functions/composer-storage-trigger/index.js

Line 61 in c00c94f

iap.jwt

Why?

[fhinkel]

@ace-n , could you have a look at this functions sample? Thanks

[ace-n]

@leahecole owns this sample (per CODEOWNERS) - over to you 🙂

[meredithslota]

I'm not sure if this makes sense but I'm adding the "composer" label so this is surfaced to our team, and dropping priority to P2.

[leahecole]

I'm investigating this now. I tried running the code in the relevant tutorial as is, and it seems to work - the DAG triggers and prints the appropriate info.

I retried adding in the jwt parameter like it was before, and the DAG triggered then too, printing the appropriate info. This occurred because the makeIapPostRequest function never reads this value. The fact that the function never reads the value is likely why it was removed in this PR that was running eslint - it removed unused parameters. The line that you highlighted managed to get leftover somehow, but has since been updated. There are now no longer any references to this unused jwt - the ones that remain are used in the service account signature request.

Thank you for opening this - I'm going to close it because as far as I can tell, the code doesn't need any updates at this time.