Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/markdown-preview/editor: Can successfully make a request to the Renderer failed #1987

Closed
flaky-bot bot opened this issue Sep 28, 2020 · 4 comments
Closed
Assignees
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Sep 28, 2020

Note: #1935 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: a3e0e4a
buildURL: Build Status, Sponge
status: failed

Test output
Response code 500 (Internal Server Error)
HTTPError: Response code 500 (Internal Server Error)
    at Request. (node_modules/got/dist/source/as-promise/index.js:117:42)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 28, 2020
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Sep 28, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Sep 29, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (a3e0e4a), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@grayside
Copy link
Collaborator

grayside commented Oct 1, 2020

Confirmed this is a flaky test, in that the test passes locally. The current implementation of e2e test code for Cloud Run samples in this repo is a mess and needs more retry logic. Going to put together a brief proposal on an overhaul.

@grayside grayside self-assigned this Oct 1, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Oct 5, 2020
@grayside
Copy link
Collaborator

grayside commented Oct 6, 2020

This flaky test is not blocking PRs, though conceivably it is driving very occasional retests.

The correct solution is to ship a fix for #1991 and see how this goes.

@grayside grayside added status: blocked Resolving the issue is dependent on other work. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 6, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Oct 6, 2020
@averikitsch
Copy link
Contributor

Closed via PR #2042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants