Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #1124

Merged
merged 3 commits into from
Sep 19, 2017
Merged

Update readme #1124

merged 3 commits into from
Sep 19, 2017

Conversation

dizcology
Copy link
Member

update readme to reflect the new method.

also putting back entity sentiment analysis to v1beta2 to avoid the false impression that it is removed from the API.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2017
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one weird nit to keep an eye out for when we publish the docs.

@@ -125,6 +126,66 @@ def entities_file(gcs_uri):
entity.metadata.get('wikipedia_url', '-')))


# [START def_entity_sentiment_text]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the other blocks don't have includecode blocks.

@theacodes theacodes merged commit a02123e into GoogleCloudPlatform:master Sep 19, 2017
busunkim96 pushed a commit to busunkim96/python-language that referenced this pull request May 20, 2020
* update readme

* keep entity sentiment in v1beta2 as well

* update readme
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
* update readme

* keep entity sentiment in v1beta2 as well

* update readme
busunkim96 pushed a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
* update readme

* keep entity sentiment in v1beta2 as well

* update readme
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
* update readme

* keep entity sentiment in v1beta2 as well

* update readme
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
* update readme

* keep entity sentiment in v1beta2 as well

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants