Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[translate] glossaries are likely leaking in the cloud-client tests #3550

Closed
tmatsuo opened this issue Apr 24, 2020 · 2 comments · Fixed by #3572
Closed

[translate] glossaries are likely leaking in the cloud-client tests #3550

tmatsuo opened this issue Apr 24, 2020 · 2 comments · Fixed by #3572
Assignees
@munkhuushmgl
Labels
api: translate Issues related to the Cloud Translation API. priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 24, 2020

I saw an error in #3495

Log:
google.api_core.exceptions.ResourceExhausted: 429 The number of glossaries for the project exceeds the allowed maximum. max_glossaries = 1000

I manually deleted all the glossaries in the test project, but tests are very likely leaking glossaries.
This bug is to stop the leak.
@tmatsuo tmatsuo added testing priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: translate Issues related to the Cloud Translation API. labels Apr 24, 2020
@tmatsuo tmatsuo mentioned this issue Apr 24, 2020
Merged
@munkhuushmgl
Copy link
Contributor

I will fix this

@munkhuushmgl munkhuushmgl mentioned this issue Apr 28, 2020
Merged
@munkhuushmgl
Copy link
Contributor

@tmatsuo Could you take a look this PR #3572?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munkhuushmgl munkhuushmgl

Labels
api: translate Issues related to the Cloud Translation API. priority: p2 Moderately-important priority. Fix may not be included in next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

translate: fix glossary leak issue
2 participants
@tmatsuo @munkhuushmgl