Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Add support of BigTable cluster autoscaling_config for "google_bigtable_instance resource" #1425

Open
akhambhala opened this issue Mar 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@akhambhala
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave +1 or me too comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If the issue is assigned to a user, that user is claiming responsibility for the issue.

Description

Add support of BigTable cluster autoscaling_config for google_bigtable_instance resource. We want to add policy to control the max_nodes in autoscaling of BigTable.
Is there any other way to read the terraform state json directly? so we can use that until this support is added.

Affected Resource(s)

Resource converter exists?

No

@akhambhala akhambhala added the enhancement New feature or request label Mar 3, 2023
@melinath
Copy link
Member

melinath commented Mar 3, 2023

Is there any other way to read the terraform state json directly?

gcloud terraform vet supports Terraform-based constraints: https://cloud.google.com/docs/terraform/policy-validation/create-terraform-constraints

@akhambhala
Copy link
Author

akhambhala commented Mar 23, 2023

@melinath I tried with gcloud beta terraform vet, but same issue, I am not able to access autoscaling_config. Even though its available in tfplan.json.
I can see only location, serverNodes, defaultStorageType, name when I print input.review which is supported https://github.com/GoogleCloudPlatform/terraform-validator/blob/main/converters/google/resources/bigtable_cluster.go#L65

Is that mean as of now there is no way to access autoscaling_config, with out adding them in https://github.com/GoogleCloudPlatform/terraform-validator/blob/main/converters/google/resources/bigtable_cluster.go#L65?

@melinath
Copy link
Member

The support for Terraform resources in gcloud terraform vet doesn't go through Terraform Validator - it just passes the resource change data directly from your plan file to the validation framework.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants