Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmer does not use existing cache #722

Closed
valentinsoe opened this issue Jul 24, 2019 · 1 comment · Fixed by #723
Closed

Warmer does not use existing cache #722

valentinsoe opened this issue Jul 24, 2019 · 1 comment · Fixed by #723
Labels
area/caching For all bugs related to cache issues

Comments

@valentinsoe
Copy link
Contributor

I am experimenting with kaniko in Gitlab CI pipelines. And I use caching extensively to provide faster pipeline execution. So I've tried to use kaniko-warmer for faster docker builds.
The problem is currently kaniko-warmer downloads images regardless of cache directory state.

I propose kaniko-warmer to check image existence in the cache directory prior to downloading it.

This will require minor code modifications. PR with them is coming.

@valentinsoe
Copy link
Contributor Author

I've implemented cache reusing in warmer and submitted PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/caching For all bugs related to cache issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants