Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when Autosave exists #3841

Closed
swissspidy opened this issue Aug 12, 2020 · 2 comments · Fixed by #12098
Closed

Add message when Autosave exists #3841

swissspidy opened this issue Aug 12, 2020 · 2 comments · Fixed by #12098
Assignees
Labels
Group: Editing Main editing features Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P2 Should do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Aug 12, 2020

Feature Description

The default editor in WordPress has this mechanism which we want to implement as well.

  1. Edit post
  2. Make some changes, triggering autosave
  3. Close window
  4. Edit post again
  5. See message like this: "There is an autosave of this post that is more recent than the version below. View autosave."

For the prototype implementation, let's create a simple modal/dialog.

Need to pass autosave information to the editor in get_editor_settings(). Prior art:

https://github.com/WordPress/wordpress-develop/blob/9b04bb68f1ec37c38d79372ba93929bf5b96e522/src/wp-admin/edit-form-blocks.php#L216-L225

Alternatives Considered

Additional Context

Screenshot:

68747470733a2f2f636c2e6c792f325a335432523273316131702f496d616765253230323031382d30312d30372532306174253230322e31332e3034253230504d2e706e67 (1)

Original Gutenberg implementation: WordPress/gutenberg#4218

@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: Editing Main editing features Pod: Prometheus (Workspace) labels Aug 12, 2020
@o-fernandez o-fernandez added the Status: Needs More Info Follow-up required in order to be actionable. label Sep 2, 2020
@o-fernandez o-fernandez added the P4 label Sep 29, 2020
@barklund barklund added the Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar label Oct 5, 2020
@swissspidy swissspidy added P2 Should do soon Pod: WP and removed P4 Status: Needs More Info Follow-up required in order to be actionable. labels Jul 14, 2022
@timarney timarney self-assigned this Aug 11, 2022
@timarney
Copy link
Contributor

For the prototype implementation, let's create a simple modal/dialog.

@swissspidy --- would this be like the font check dialog? Check for link when the editor loads - pop the modal if it does which links to the autosave.

@swissspidy
Copy link
Collaborator Author

Yeah, conceptually pretty much.

Though this can live in story-editor package as that's where the autosaving is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Editing Main editing features Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P2 Should do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants