Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(analytics): lancement dsfr start dans les pages SPA [DS-3855] #995

Merged
merged 1 commit into from
Oct 23, 2024
Merged

🐛 fix(analytics): lancement dsfr start dans les pages SPA [DS-3855] #995

merged 1 commit into from
Oct 23, 2024

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Sep 12, 2024 •
edited
Loading

@keryanS keryanS added correctif Quelque chose ne fonctionne pas à vérifier maj 1.12.1 labels Sep 12, 2024
@keryanS keryanS added this to the 1.13.0 milestone Sep 12, 2024
@keryanS keryanS self-assigned this Sep 12, 2024
zellerbaptiste
zellerbaptiste approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@zellerbaptiste zellerbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce switch case est-il à documenter pour le lancement du dsfr start dans les pages SPA ?

@keryanS
Copy link
Contributor Author

keryanS commented Sep 17, 2024

Ce switch case est-il à documenter pour le lancement du dsfr start dans les pages SPA ?

Je ne pense pas, car généralement le start se fera au mount de la SPA. Ici on intègre le framework plus localement sans gestion du cycle de vie.

@keryanS keryanS closed this Sep 17, 2024
@keryanS keryanS reopened this Sep 17, 2024
@lab9fr lab9fr added Prêt and removed à valider labels Oct 21, 2024
@keryanS keryanS changed the base branch from main to dev-1.13.0 October 22, 2024 10:29
@keryanS keryanS changed the title fix(analytics): lancement dsfr start dans les pages SPA 🐛 fix(analytics): lancement dsfr start dans les pages SPA [DS-3855] Oct 23, 2024
@keryanS keryanS merged commit 8db9b5b into dev-1.13.0 Oct 23, 2024
4 checks passed
@keryanS keryanS deleted the fix/analytics-spa-actions branch October 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

@zellerbaptiste zellerbaptiste zellerbaptiste approved these changes

Assignees

@keryanS keryanS

Labels
correctif Quelque chose ne fonctionne pas maj 1.12.1 Prêt
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Collecte des statistiques avec l'API analytics sur les actions pour les frameworks VueJS et ReactJS
3 participants
@keryanS @lab9fr @zellerbaptiste