Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak #24

Open
d3roch4 opened this issue Oct 29, 2015 · 2 comments
Open

Memory leak #24

d3roch4 opened this issue Oct 29, 2015 · 2 comments

Comments

@d3roch4
Copy link

d3roch4 commented Oct 29, 2015

Memory leak
in RequestHandler.h file: 29 this allocating a Response
and Controller.cpp file: allocating another 113 this Response.
At the end apens one will be deleted causing a memory leak.

My suggestion is to move the Controller method :: serverInternalError the Controller class to RequestHandler class, I'll implentar this and commit on my fork.
@Gregwar
Copy link
Owner

Gregwar commented Oct 29, 2015

Would you mind making a pull request?

@d3roch4
Copy link
Author

d3roch4 commented Nov 10, 2015

pull request: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gregwar @d3roch4