Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA backend temporaries should respect CUDA alignment guidelines #1459

Open
anstaf opened this issue Apr 2, 2020 · 1 comment
Open

CUDA backend temporaries should respect CUDA alignment guidelines #1459

anstaf opened this issue Apr 2, 2020 · 1 comment

Comments

@anstaf
Copy link
Contributor

anstaf commented Apr 2, 2020

A minor problem with this: vertical advection is the only our regression that use temporaries in cuda; our perftests use power of two domain sizes. Hence we need yet another test to track the performance improvement of that change.

@havogt havogt changed the title cuda backend temporaries should respect CUDA alignment guidelines CUDA backend temporaries should respect CUDA alignment guidelines Apr 3, 2020
@havogt
Copy link
Contributor

havogt commented Apr 3, 2020

The idea is to align the first domain point of each CUDA block. Currently, we align to the first halo point of each block.

We came to the conclusion that this is likely only a minor performance improvement for only very specific stencils:

  • pure vertical stencils are well aligned as they don't have a halo (no improvement)
  • pure horizontal stencils should use the cuda_horizontal backend or ij caches (no improvement)
  • for mixed stencils it depends probably on the stencil which alignment is better (maybe an improvement)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants