Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To figure out if strides_kind (aka storage_id) feature is useful. #1461

Open
anstaf opened this issue Apr 2, 2020 · 1 comment
Open

To figure out if strides_kind (aka storage_id) feature is useful. #1461

anstaf opened this issue Apr 2, 2020 · 1 comment

Comments

@anstaf
Copy link
Contributor

anstaf commented Apr 2, 2020

This feature is for sure useless for non cuda backends. For cuda the performance benefit can come from:

  1. saving on the overall strides size while passing the data to the kernel;
  2. calculating offsets for several fields in one go.
    The later was checked once on dycore — the result is that it doesn’t affect performance.

Getting rid from this feature support allows to simplify SID concept definition and the sid::composite implementation (which is the most complex metaprogramming part of our data base).

@havogt
Copy link
Contributor

havogt commented Apr 3, 2020

Postpone investigation until we can test it again on a possible GT2.0-dycore (and maybe can also investigate on different hardware, e.g. AMD GPUs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants