Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Scrollbar doesn't hide when using custom classnames #238

Closed
adjourn opened this issue Nov 13, 2018 · 1 comment
Closed

[Bug report] Scrollbar doesn't hide when using custom classnames #238

adjourn opened this issue Nov 13, 2018 · 1 comment

Comments

@adjourn
Copy link

adjourn commented Nov 13, 2018

🐛 Bug

Current Behavior

If you use custom classnames, scrollbar doesn't hide when it should be, it doesn't hide at all. This can't be avoided by not passing custom visible classname because class will be undefined then (see #228).

Expected behavior

Scrollbar should hide if cursor doesn't move for X amount of time or is moving out of scroll area.

Suggested solution

Bug is right here: https://github.com/Grsmto/simplebar/blob/master/packages/simplebar/src/simplebar.js#L569-L582

visible is hardcoded in hideScrollbars method, it should be this.classNames.visible.

Environment

SimpleBar 3.1.0-beta.5

@adjourn
Copy link
Author

adjourn commented Nov 14, 2018

Fixed in #239, closing.

@adjourn adjourn closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant