Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when creating SimpleBar with wrapContent set to false #64

Closed
GREsau opened this issue Mar 20, 2017 · 5 comments
Closed

TypeError when creating SimpleBar with wrapContent set to false #64

GREsau opened this issue Mar 20, 2017 · 5 comments

Comments

@GREsau
Copy link

GREsau commented Mar 20, 2017

In v2.2.1, creating a SimpleBar with the wrapContent option set to false fails with this error:

TypeError: this.contentEl is undefined

As far as I can tell, this was introduced in 7df8410, as this.contentEl is now only assigned to when wrapContent is true

@Grsmto
Copy link
Owner

Grsmto commented Mar 20, 2017

Thanks for this.
This project needs tests asap! :o

@wasd171
Copy link

wasd171 commented Apr 16, 2017

I experience the same issue with 2.2.2. It is fixed in the source code, but packaged version still does not assert correct values to this.contentEl and this.scrollContentEl

@Grsmto
Copy link
Owner

Grsmto commented Apr 16, 2017

Hi, I just release a new version 2.3.0 that should solve this issue. Let me know, thanks!
https://github.com/Grsmto/simplebar/releases/tag/v2.3.0

@wasd171
Copy link

wasd171 commented Apr 16, 2017

@Grsmto thanks! works fine for me. Is it on npm already too?

@Grsmto
Copy link
Owner

Grsmto commented Apr 16, 2017

@wasd171 yes it is!

@Grsmto Grsmto closed this as completed Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants