From dcd11e9384f168d125d2b60941d4bff161799824 Mon Sep 17 00:00:00 2001 From: Grex Date: Tue, 21 Feb 2023 14:13:23 -0700 Subject: [PATCH] fix: address some lint violations (#219) --- .rubocop.yml | 2 +- lib/apollo-federation/schema.rb | 2 +- spec/apollo-federation/schema_spec.rb | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 66f2b61ac..814444300 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -49,7 +49,7 @@ Metrics/ParameterLists: Max: 5 CountKeywordArgs: false Metrics/LineLength: - Max: 100 + Max: 120 Exclude: - lib/apollo-federation/tracing/proto/apollo_pb.rb diff --git a/lib/apollo-federation/schema.rb b/lib/apollo-federation/schema.rb index 36f35d8ab..e3ccd2375 100644 --- a/lib/apollo-federation/schema.rb +++ b/lib/apollo-federation/schema.rb @@ -12,7 +12,7 @@ def self.included(klass) end module CommonMethods - DEFAULT_LINK_NAMESPACE = 'federation'.freeze + DEFAULT_LINK_NAMESPACE = 'federation' def federation(version: '1.0', link: {}) @federation_version = version diff --git a/spec/apollo-federation/schema_spec.rb b/spec/apollo-federation/schema_spec.rb index 407e5e460..ff04aca03 100644 --- a/spec/apollo-federation/schema_spec.rb +++ b/spec/apollo-federation/schema_spec.rb @@ -14,7 +14,7 @@ expect(schema.federation_version).to eq('1.0') end - it 'returns the specified version when set' do + it 'returns the specified version when set to 2.0' do schema = Class.new(GraphQL::Schema) do include ApolloFederation::Schema federation version: '2.0' @@ -23,7 +23,7 @@ expect(schema.federation_version).to eq('2.0') end - it 'returns the specified version when set' do + it 'returns the specified version when set to 2.3' do schema = Class.new(GraphQL::Schema) do include ApolloFederation::Schema federation version: '2.3' @@ -88,7 +88,7 @@ expect(schema.federation_2?).to be(true) end - it 'returns true when the version is a string greater than 2.0' do + it 'returns true when the version is a string equal to 2.3' do schema = Class.new(GraphQL::Schema) do include ApolloFederation::Schema federation version: '2.3'